If we do build 'space colonies' I'm not sure that they'll be that different. The main reason behind these designs is to use centrifuge force to create artificial gravity. So until and unless we do invent some real Sci-Fi artificial gravity this remains our best approach and so are these spinning designs.

I think we'll actually see more of similar designs, even if much smaller, e.g. in spacecrafts for human journeys beyond the Moon and, indeed, space stations.

Interestingly, many very recent Sci-Fi movies involving realistic-ish human space travel feature spacecrafts with spinning toroidal living quarters.