While competing against other companies this strategy worked as MS were larger and able to have a more complete solution. This was enabled by their huge share of desktop computing with Windows. However as the shift to Web and Mobile came, the number of platforms grew (especially outside of MS controlled ones), and the centrally planned .NET experience was breaking down. MS's centrally planned competitors threw in the towel or had gone bankrupt. Java was opened, Sun was out of business and the smaller software development offerings had long since tried to incorporate open source, or had switched to growing only through milking the existing customer base.
Microsoft saw the change coming, as well as the move to the cloud, and was able to see the cost involved with competing against open source, and started their shift to open source. The foundation is their attempt to both reduce their relative investment, by having users start taking on some of the development while controlling the core of the language. Keep in mind this was the time .Net was becomming cross platform, with linux becoming a major hosting option.
Due to these origins it has lead to the foundation being in a central position in the .Net ecosystem. As such if your library is part of the foundation, its likely to be THE standard solution in the .NET space. So the advantage you get is you get to participate, and if your project joins, it becomes the de-facto standard for .NET. That credibility is likely worth a bit for consultants and definitely paints you as an expert in that field. The downside is you cede control. I am not arguing that it is worth it for most people / projects, however I can understand why people want to be involved.
.NET has today more funding in Microsoft than ever (this is a gut feeling from seeing the things they move).
The argument Project being part of the foundation equals de-facto is not correct. I think there is zero evidence for that. It is however often the other way around, that successful projects fold into the foundation because of it being the de facto foundation and no other foundation has strong ties to .NET
Beyond that, the .NET foundation would, in theory, also be able to provide resources for project maintenance (think CI hours) and events (funding for conferences/meetups etc.).
(Disclaimer: I am entirely uninvolved, this is what I recall from reading the discussions.)
Maybe this also depends on how litigious your current context of development/living/residence is.
Looking at some individuals that apparently did get into some legal stuff: it has almost always turned out fine, and when needed the EFF and FSF have been helping plenty.
If legal issues are really a thing, then a foundation isn't what we need, but just more money and people for the EFF.
My understanding is that the legal benefit of being a member project is essentially just that they run the CLA bot. If you actually get sued you're still on your own.
The .NET foundation was supposed to make C# a vendor and platform agnostic language from what I understand, giving Microsoft and others like Xamarin a seat at the table.
AFAIK ~all of the people who work there are on the Microsoft concentration-camp-money payroll.