Hacker News Reader

Stop giving them the full answer and only lead them part way there. They will then (hopefully) learn how to look up documentation for themselves. Essentially "teach a man to fish". They don't necessarily want to know the answer, but they want to know how you know the answer.

View on HN

That is what I am trying unsuccessfully to do. I made a sugestion the other day and did not write the code. He understood the idea but implemented poorly. When I asked why did he implement it that way, he said "it was your suggestion". I tried very very hard to not explode here...

That is what code review is for. It shouldn’t be personal, it’s just here these specific changes will make it more robust or easier to understand or whatever.

Explain why the implementation is poor, e.g. if there is an unperformant loop that will struggle with large workloads, point that out and ask them to write a test to simulate this, then fix the implementation.

Reply on news.ycombinator.com