I don't think port knocking is security by obscurity. It is another layer of secret that must be known (or guessed) to gain access.