Total BS too. Maybe in India."
This is not BS. My company in the US expects you to be performing at the next level before promoting you. Where do you work? I work at a company that is regarded as doing the right thing and having good intentions, yet they will make you work for up to years in a role above your own before promoting you.
I did this for at least a year before getting promoted to midlevel. Then I performed the role of senior dev and then tech lead for a year each and still did not get promoted. (They started to talk about it, but wanted me to take a 13% increase in hours for a 7% raise - that's not a real promotion in my book)
I would say the list the OP posted is not great. It might be generally applicable, but every company is so different that it doesn't really matter. Even in the same company with a standardized process, promotions can vary greatly from manager to manager.
I hate visibility. I do begrudgingly agree that it's necessary to get promoted in most companies. I really think that talent identification and rewards should be handled by the managers. Having people toot their own horn can take away from the team spirit between members and even create a perverse motive for what work/tasks people are willing to do. I've seen terrible tech leads that only for to where they did because they were yes men and would take credit for putting out fires - fires that were a result of their own shortsighted designs.
But hey, I guess that's why I'm still a shitty midlevel dev that's only seen a 30% (22% inflation adjusted) pay increase over 9 years and doesn't even make $100k.