I think this is a good list, one needs to know potential pitfalls and plan accordingly.
As for point #7, if your upgrade requires hours, you are holding it wrong, try pg_upgrade --link: https://www.endpoint.com/blog/2015/07/01/how-fast-is-pgupgra...
(as usual, before letting pg_upgrade mess with on disk data, make proper backups with pg_basebackup based tools such as barman).