For stability of the region, commerce, peace and moderate forces in all parties, it was a good deal.
It wouldn't have resolved all the issues the world has with Iran, but the idea of having a "deal" in place that resolves all issues is childish.
Eg can the US have a "deal" with Saudi in place to resolve all the regional and human rights issues with them? Of course not. But those who argue against the JCPOA claim the US could've had a "deal" with Iran that resolved all issues.
It would've been used to rebuild some trust between both nations and help resolving other issues in long term.