For the longest time I have been a foobar/winamp user on Windows.
But on Linux, the music player situation is atrocious. I surrendered to VLC et voilà. It bugs me to no end that I use a video player to play music files but that's life.
It plays everything, it doesn't need an insane backend scanning framework, it doesn't randomly crashes, its controls have been consistent for years and I can easily select the output device. I hate using it to play music but I love that I can use it to play music.
Oh, and I can't wait for someone to release a VLCMedia distro with a keyboard/kiosk mode to get rid of XBMC/Kodi which has an insane amount of incoherent keybindings and defaults.
edit: I also use cvlc to create an RTSP stream from pi-0, those streams are read and converted by a pi4 to HLS files in ssh shared folder with a VPS that has an index.html file with a js player. Works flawlessly. Only downside is when wifi gets flaky. How cvlc is the easiest and fastest option to do that on a pi0 is beyond me but thank you.