Dark Mode Coming to GitHub After 7 Years
github.com
github.com
Like GitLab does: https://gitlab.com/gitlab-org/gitlab/-/issues
If they did, we wouldn't have to rely on random issues on random repos.
Isn't the implementation of 'Dark Mode' little more than a CSS Color palette and a toggle switch nested somewhere in user settings?
Are people celebrating the usability over the technical feat?
Seems like much ado about nothing :/
I wish open standards were this popular.
I'm confused about what you find questionable about this, are you saying we shouldn't accommodate people with disabilities?
And dark mode is often done poorly. If you could just flip the colors, you could use that phone feature that does that to get the same result but you can't. That typically looks like crap and works poorly.
Hopefully it will be based on the prefers-color-scheme media feature, instead of it being a setting to toggle…
<picture>
<source src=screenshot-dark.png media="(prefers-color-scheme: dark)">
<img src=screenshot-light.png>
</picture>
And then if the site is doing dark mode toggling by some means other than `@media (prefers-color-scheme: dark)`, it can go through and rewrite the media queries in all user-generated content, e.g. to change that one to media="all" in dark mode or media="not all" in light mode.Exciting still <3