I use iCloud photos a ton and my old 128GB Mac's disk is constantly full just from the non-removable thumbnails for iCloud photos, without any actual photos on my local machine.
I've been fighting disk space issues with my Mac for the past five years because I was short-sighted and only got the 128GB disk. This time I went with 1TB, not making that mistake again.