Interesting concept but digging a big hole sounds expensive and prone to flooding. I can see how this would have better efficiency than pumped-storage hydro but I wonder if you couldn't raise and lower weight near cliffs rather than drilling wells.
If it does work, I would imagine the Boring company would be all over this.