Some locksmiths really don't like locksport folks. I think there are multiple reasons but the most basic might be that they think it will result in fewer calls.
I have some very basic picking skills and for me, anyway, it's actually given me tremendous respect for the locksmith trade and made me more likely to call them when warranted, because I understand the wider range of things they can do and the skill it takes to do them successfully.
The ability to make a key for locks which have no key is another, even if those locks don't have removable cores (I'm thinking of mostly padlocks here). That's a really cool thing called impressioning, where the mechanics of the lock (pins pressed down into the keyway by springs) are actually used against it to progressively turn a key blank into a working key.
Master keying is another great example (when multiple, different keys work in a lock and you can have one key that works in multiple locks, such as a small apartment building).
Also a lot of ancillary things around the lock but not the lock itself, for example installing deep screws or replacement anti-kick hinges (door devil or door armor). In theory those are DIY things but in practice you can spend a lot of time trying to get alignment right (especially with a deadbolt going smoothing in/out), but it's something a locksmith does all the time.
Since he acted like a reasonable (rational) person he probably wasn't a scammer, but it's worth mentioning that there are locksmith scammers who take advantage of people in high-need situations to charge them exorbitant amounts for "unpickable" locks that always need to be drilled.
The Reply All podcast covered this a few years ago with "Very Quickly to the Drill" [1]
[1]: https://www.art-of-lockpicking.com/how-to-pick-a-lock-with-a...