Hacker News Reader

Hacker News

Comment by notkaiho | Hacker News Reader

Full thread

notkaiho

I'm no expert in C++ so not sure if it's meant to look like that, but that code is making my brain hurt.

View on HN

Just argument parsing makes my eyes bleed...

https://github.com/mrc-ide/covid-sim/blob/master/src/CovidSi...

That stuff is priceless:

else if (argv[i][1] == 'C' && argv[i][2] == 'L' && argv[i][3] == 'P' && argv[i][4] == '1' && argv[i][5] == ':')

I guess string comparisons are complicated. I also fail to see why they used ':' as the separator and why they didn't use a proper library to parse argv...

Because when you have only a very limited number of arguments it’s easier to do it that way than selecting a lib, adding it to the project, reading the doc, trying it and integrating it for real. I add the issue in C#, and after trying 2 or 3 libs (including one by Microsoft) I just gave up.

I hear you but in their case they have more than 130 LOC to parse ARGV. Doing all that manually hurts both code readability and maintainability.

Having seen a discussion about this on a different forum, someone who used to work in academia mentioned that repeatability and consistency are key to academic code, which means often readability and convention may get sacrificed - it works for the author and if someone wants to repeat the experiment it should get the same results without wangling around with many external packages or modules that may change or become obsolete.

Still hurts to read though :P

Yep. Also, speaking from academic point of view, code won’t make you advance on your career by itself (only papers based on it will), so the minimum is done until the thing is usable for its goal. So forget about CI/CD, proper test suits, documentation (I hate this point personally and document my projects a bit more than the average researcher) and engineering best practices.

Then public policy should heavily discount results based on academic code, if it shown to be poorly engineered. I'd go further and say you can't trust the papers based on the results of badly engineered simulations. As a poster said earlier "I think there should be fairly high standards of scientific rigor even in published code, especially if this might impact public policy actions, like we should expect high rigor in biological and epidemiological studies."

...what do you think those biological and epidemiological studies hinge on? ;)

In my very limited experience, that's what a lot of code coming from academia looks like.

That code reminds me of a program that emulated an old Wyse Color Terminal.

it is not meant to look like that. The spacing/tabbing is all over the place.

'Academic code' is infamous for having that effect.

Reply on news.ycombinator.com