The opt-out does seem to be preserved after an upgrade. I had it off, ran the upgrade, and checked with `brew analytics`.