> Survivorship bias is anyone who has had success at a task, regardless of how long it took.
I don't believe that. It depends on the task and how much of it is chance vs. skill. Winning the lotto is literally 100% chance, 0% skill. Odds are worse than 1 in a million, so yes, I agree with your assertion that a lotto winner who played for 40 years and finally won is exhibiting survivorship bias if they claim the key to winning is playing every week.
However, if I have a goal to run a 6 minute mile, and I fail 100 times before I finally succeed. Does that mean I have survivorship bias if I say that I found running a little faster every day and not giving up to be the key to success?
Dating does have an element of chance, yes, but it also has an element of skill - you get better social skills the more you use them. It's a bit disingenuous to compare "the dating game" (which billions of people "win" every year) to lotto (which probably < 100 people win per year).
If I had to start the dating game all over knowing what I know now, I'm confident I could find a wife much faster than my first time around - especially with the help of online dating apps. I'm older and wiser and I understand females now way better than I did when I started out.