Speaking as a software engineer who became an attorney, I would say that most attorneys could benefit from basic programming knowledge (e.g., simple scripts, macros, and SQL).

I say this because the bulk of work for many types of legal practice is information filtering/search/organization/and presentation, both in wrangling evidence and in exploring the law itself. Basic programming knowledge can do great magic in terms of making these processes more efficient, such as by programmatically manipulating the hundreds or millions of files that can be produced in legal cases.

In terms of more in-depth knowledge of programming, there is a definite place for it in the law (it has worked to my benefit), but I think that role is specialized/limited. I think improved software tools will, generally, fill the profession's need rather than every attorney attempting to specialize in another field enough to roll their own apps.