Sqlite makes all its asserts noop in release mode[1].
Chrome disables DCHECK() in release mode[2], and it's used many times[3].
RE2 has debug only checking[4].
In Rust debug mode, signed integer overflow panics, in release mode it wraps[5].
Firefox disables MOZ_ASSERT() in release mode[6], and it's used many times[7].
I doubt Huawei is more modern and less 1980s than all these other projects.
>My money is on Huaweis function doing the check with an assert which was compiled out for deliverable code.
Are you saying it was compiled out because asserts were disabled, or because the compiler could reason about the arguments at every callsite? It seems unlikely to me that the compiler could reason about the arguments at every callsite.
[1] https://www.sqlite.org/assert.html
[2] https://chromium.googlesource.com/chromium/src/+/master/styl...
[3] https://cs.chromium.org/search/?q=DCHECK%5C(+case:yes&sq=pac...
[4] https://github.com/google/re2/blob/master/util/logging.h
[5] http://huonw.github.io/blog/2016/04/myths-and-legends-about-...
[6] https://dxr.mozilla.org/mozilla-central/source/mfbt/Assertio...
[7] https://dxr.mozilla.org/mozilla-central/search?q=MOZ_ASSERT(...