How does Dark handle code review?
Even if I was willing to accept the other tradeoffs that come with Dark, I'd want another human to approve my changes before that 50ms deploy to production kicks off.
Even if I was willing to accept the other tradeoffs that come with Dark, I'd want another human to approve my changes before that 50ms deploy to production kicks off.
So to do code review, you write the code behind the feature flag, then ask someone for code review. (There's google-docs style collaboration, so they can see your code if you permit it). After code review, you can "merge" by toggling the feature flag, or changing the setting to "let 10% of users see this" or whatever roll-out strategy you want.
just safely. So you're writing code behind a feature flag (but "in prod"), but no users can see it.
In traditional design, there will be pre-commit code reviews and staging env with limited access. But looks like Dark get rids of all of this?
But it is one of the few steps the Dark deployment process retains (see the diagram near the end of the article), so it seems they will support it (hopefully reasonably well).
It requires the language to have a bulletproof feature flag system which can't be bypassed, which it seems is the goal.