Hacker News Reader

You actually bring up a question I've wondered about for along time. To most people here does "code review" mean a synchronous meeting (either in person around a conference room, or remotely via screen share) where you talk out loud about the code? Or does it just mean setting up "review/approval" requirements for pull requests in your GitHub/GitLab/BitBucket instance?

View on HN

I have participated in multiple types.

1:1 code review in person, sort of like pairing at that point. 1:1 remote via PR, 1:N in person in front of a screen or projector, 1:N remote where you need multiple approvals and different sections may interest different people, and N:M where a small team worked on a feature and request another teams review.

I think of review broadly as the remote/pr kind. But all of these are valuable in different situations.

My favorite is N:M since it gets the most eyes on a problem. Hard to scale without slowing down the process (eg. standards bodies).

Reply on news.ycombinator.com