I quite like keepassx. Sync's with a dropbox file and I can use it across all my devices. It's not that fancy but has done the job for years on my systems.
I originally used LastPass for a long time, but it went downhill fast with its sale to LogMeIn and the retirement of the old Firefox extension.
Switching to BitWarden was a delightful experience and I haven't been disappointed with it yet.