This is true for the majority of students, but not generally true for the top ~1-10% of students who often need all 4 years to compete for slots at top law schools, med schools, phd programs, and employers. And getting into the top 4-5 of any of those things (except maybe phd programs, outside of a few fields like CS) will pay itself back in spades.
I'd be curious to see a study that figures out who thinks they are in that 1%-10% vs. who actually is. I.e., are people just being idiots, or are they over-estimating the trajectory of their early career?
Also, even for the other 90%, the same is true for lots of stuff. Including housing and vehicles. People aren't rational.