Isn't this ignoring that a lot of upzoning comes with the requirement that a percentage of new units are made to be affordable? (at least that's the case in recent Seattle projects I've seen)

Sure, if the market is completely free then it will build the highest value items (shwanky condos), but that's (thankfully) not the world we live in.