Linus hasn't lost his touch, if this is any indication:
Linus identified that there was an unacceptable action taken and Is being stern so that there can be no ambiguity in the future as to what the accepted action ought to be.
I believe that’s what I said, no? Maybe my phrasing wasn’t clear, but I said “I don’t see any of the latter here” with latter being “personal attacks”.
> Linus identified that there was an unacceptable action taken and is being stern so that there can be no ambiguity in the future as to what the accepted action ought to be.
Completely agree with this sentiment.
Actually, instead of hot like before, this Linus is cold. Instead of raging, he coldly expresses his disappointment. In some ways, this feels more brutal than his old style.
Criticizing the mistake as "complete garbage" is great. You don't even need to read anything more to sense Linus is annoyed like he always is when shit hits the fan like this.
Your other comments around that time seemed to be critical of his current behavior, but I see you are correcting that now.
Maybe a CoC and some time off for Linus wasn't all that bad after all...
I assume the downvotes are coming from those who disagree with the CoC.
Anyway, it looks too polite, like he is filtering the email using a "polite" version of the "simple" English writer by xkcd https://xkcd.com/simplewriter/
He's just more choosy about his wording.
Nevertheless, he gets his point across very well:
> Yeah, this is complete garbage.
> Eric, your behavior is entirely out of line
> There are no excuses.
> I will not take any pull requests from you until you have made it clear that you comprehend this very fundamental issue.
Now, Linus may not be explicitly swearing ~ but it comes across in the very same annoyed manner.
Best burn here is him flatly telling Eric that he won't be pulling anything from him until he fixes his attitude.
It's not the contributors personal attitude that's in question here but his attitude towards breaking user space, so it's not even ad hominem or anything.
> Eric, I want to make this 1000% clear: there are no user space bugs.
> If it used to work, then user space was clearly doing the right thing.
> The fact that you tried to several times claim it was buggy user space is a serious breach of trust.
I find Linus' wording remarkably polite. Surely you're not suggesting that Linus should accept breakage of user space out of sheer politeness?
What I meant by attitude is exactly what you meant ~ the nonchalant attitude towards breaking userspace, and thinking that it's okay if no-one notices.
Which is when Linus gets the most pissed of all.
Linus was polite, yes, but he expressed his anger and disappointment in a great way. Feels more brutal than his old style, actually.
Yea, it's even stronger without the swearwords.
> Linus hasn't lost his touch,
I misread that comment of yours as "Linus is still being too rude".
Basically, Eric might be forced to go through others, who will examine his work for pulling quality.
If Eric can prove that he's changed for the better, Linus may well start pulling from him again.
Linus isn't some evil dictator ~ he's just trying to make a point that quality matters.
He was both polite ~ yet criticizing. His expressed his annoyance in a great way.
"Complete garbage" is polite for Linus, compared to his old style. Still brutal, yet effective.
Linus is something of genius when it comes to criticism, whether he's swearing and venting, or coldly and bluntly saying the above to make a point.