Not if the hydrogen comes from hydrocarbons, which right now is all hydrogen. In this case, it's just an inefficient proxy for fossil fuels...
It's not! the Scandinavians are investing in "green" hydrogen, you should look at the photos of the giant electrolysers in this PDF: http://hydrogenvalley.dk/wp-content/uploads/2017/09/FCB-CPH1...
The bigger issue for railroads is range; current battery operated trains have a range of about 40km, whereas this hydrogen train has a range of 1000km. You could have charging stations at every station, but then you run into issues if the distance between stations is more than 40km, or if the charging equipment at a station becomes broken.
Hydrogen is a terrible battery with very little chance to catch up to current battery tech.
That's why it's stuck in the demonstration phase, essentially.