https://www.irs.gov/charities-non-profits/substantiating-cha...
States are already allowed to let one deduct charitable contributions from state taxes however they like. And visiting a park one donates to isn't considered quid pro quo. These cases will be complicated and interesting.
[1] https://www.irs.gov/charities-non-profits/substantiating-cha...
EDIT: Stated specifically, for NY: "The Budget establishes a charitable gift trust fund in the joint custody of the New York State Commissioner of Taxation and Finance and the State Comptroller."
[0] https://www.budget.ny.gov/pubs/archive/fy19/enac/enacted-tax...
Hence my argument for the lack of a quid pro quo. The charity gets the quid; someone else provides the pro quo. How states and municipalities count their tax obligations could be argued to be local issues, from a Tenth Amendment perspective. (We just had a landmark anti-commandeering case get decided on by SCOTUS.)
Here's a clearer quid pro quo: churches.
Charities and municipal governments are legal fictions of the states. I do not know the specifics of how these charities are set up. I presume they are ownerless non-profits. (If not, the New Jersey legislature could simply create such an entity type.) Determining common control with municipalities will be tricky.
That they are creatures of the states, and not the federal government, is what will make the lawsuits interesting. The most realistic pathway for the IRS would be to argue these charities do not qualify as such under federal tax law. How they will do this, within the confines of the 10th Amendment and a haphazardly-written tax code, without hitting other charities, will be delicate and complicated.
In the case of school districts, easily the largest line item of the SALT liability for New Yorkers, The quo would be educational services. Anyone who donates to one of these "charities" and then puts a child in the school system could be at serious risk for tax evasion. It doesn't matter legally if the "charity" is also floated by other revenue streams. It's about what the filer claims and what he receives. I am pretty sure the IRS has a history of formulas to apply for figuring out how much is rendered in services[0]. Per pupil expenditure would be a likely candidate. Perhaps those with no children in the system would be safe.
The analogy with the church would be if they were giving your child a free or discounted on religious school admission as a contingency of how much money you donate. You can't write off donations like that[1]
[0] https://www.irs.gov/pub/irs-pdf/f8283.pdf
[1] https://www.irs.gov/publications/p526#en_US_2017_publink1000... - "Contributions From Which You Benefit": .... "Tuition, or amounts you pay instead of tuition. You can't deduct as a charitable contribution amounts you pay as tuition even if you pay them for children to attend parochial schools or qualifying nonprofit daycare centers. You also can't deduct any fixed amount you must pay in addition to, or instead of, tuition to enroll in a private school, even if it is designated as a "donation."
This is a news article about a notice they've just issued indicating as much.
The law is not a computer program. Being clever about definitions does not often have pleasant results. This approach is unlikely to work.
The IRS is powerful. But so are the states. If you think this is a simple case, you're mis-understanding it. Fully expect this to go to the Supreme Court.