Hacker News Reader

Comment by danielrw7 | Hacker News Reader

Yes, but the package.json's production dependencies [0] includes codecov [1] for CI which includes request [2] which includes another 22 dependencies. Moving that to the devDependencies should be fine since the main script doesn't require any modules.

[0] https://github.com/talonbragg/message-palette/blob/master/pa... [1] https://www.npmjs.com/package/codecov [2] https://www.npmjs.com/package/request

View on HN

This is exactly what I mean. Looking at the repo there are a ton of packages in `node_modules` dir for a lib that should have 0 to a handful of dependencies.

People will be more likely to use this lib if it's cleaned up a bit. I'm pretty new to using JS/npm and one of my least favorite parts of it this:

    npm install some-package
    1400 packages installed

So seeing packages that have a bunch of stuff in their node_modules gives me pause about using it, especially when it's not clear to me why it would need all those things.

Yeah, it's very easy for npm dependencies to get out of hand. What I didn't notice when I made my comment (and what you commented on) was that the node_modules dir was actually added to the git project. If that were removed (and a .gitignore line added) and the package.json dependencies were fixed then it should truly have no dependencies upon install.

Yep, it's a bit uncommon to store node_modules in git these days (since we have npm shrinkwrap). I've sent a PR, and another one to stop the message disappearing with unsupported color.

Also, the package author is 12 years old (http://talonbragg.com/). I'd say this stuff is pretty impressive.

Reply on news.ycombinator.com