Hacker News Reader

Comment by diggan | Hacker News Reader

This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise...

Speaking about finding test failures quickly though, Jenkins and many others (except ALL the cloud/SaaS solutions?) actually parse test results via junit or similar to show you failures easily. I'm wondering why more SaaS don't do this?

See an example here (for our js-ipfs project): https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ip...

It's so much easier to find test failures now and doesn't involve leaving a comment on the PR. It's simply two clicks to find this view from a PR (click the status message, click on "tests")

View on HN

disclaimer: Developer Evangelist at CircleCI

re: parsing test results

CircleCI has been doing this for years. Not only does CircleCI read and store JUnit formatted test metadata but provides a dashboard called "Insights" to show this data overtime.

A Doc on collecting this data can be found here: https://circleci.com/docs/2.0/collect-test-data/

re: Code coverage spam

Thank you! I've often felt this way but never seen anyone else mention this. For many code coverage tools, you can integrate them at the GitHub point, which then gives you that "code coverage spam" or you can integrate it with a CI provider. This can simply fail a build if coverage drops. You can always have a status badge that shows coverage % in the readme as well.

Thanks for the feedback, we're working on methods to prevent TravisBuddy from commenting if the PR is being rapidly updated or if its comments are not relevant for some reason. One idea is that if the PR has a special label TravisBuddy won't comment on it. Another one is to be able to communicate with TravisBuddy using comments, so when you're sick of it you could just comment: "@TravisBuddy stop", and it'll stop immediately. (Maybe even "@TravisBuddy clear" to remove the previous comments)

Yeah, Jenkins' tests view was one of the inspirations for TravisBuddy :)

You can do what codecov does; They keep updating the same comment with the latest result.

That's an awesome idea, will be a feature for sure.

> This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise...

IIRC at least Codecov (https://codecov.io) has logic to go in and update the existing comment rather than spamming with new ones. It's nice!

CircleCI will parse and collect JUnit test metadata. https://circleci.com/docs/2.0/collect-test-data/

Reply on news.ycombinator.com