Wow 6k lines of bash script with 1.6k tests file [1].
Looks a bit nightmarish to maintain.
1 : https://github.com/Neilpang/acmetest/blob/master/letest.sh
Looks a bit nightmarish to maintain.
1 : https://github.com/Neilpang/acmetest/blob/master/letest.sh
The measure should be whether you can get your head around the whole script at once. I'm fairly sure I can do that. It's a clean example of getopt, makes full use of coreutils (and in an idiomatic way). It handles various OS and shell compatibility issues (and shows it has experience with where these arise). It does logging in a straightforward yet full-featured way.
As usual almost every comment here on HN is superficially critical.
Take a look at how the tests are invoked :
for t in $(grep ^le_test_ $FILE_NAME | cut -d '(' -f 1)
do
if [ -z "$CASE" ] ; then
__green "Progress: "
[ "$_ret" = "0" ] && __green "$_ret" || __red "$_ret"
__green "/$num/$total"
printf "\n"
num=$(_math $num + 1)
fi
...
Bash works perfectly with "Write programs that do one thing and do it well". Wouldn't be so surprised if this was a bunch of small test cases separated by file.
le_test_xxx # <- this is not a comment anyway
# le_test_xxx does something nice. # <- doesn't match ^le_test_Edit: In case people don't know about Certbot from the EFF.