They are still useful for lumping your traffic in with others for copyright infringement. Torrent clients offer the files for sharing while downloading.
They are still useful for some simple geo evasion as well.
They aren't a solution for every security issue at all. Tor is generally better to run from open wifi from a tails USB rather than from a VPN.
Also, many VPNs actually log things they can provide to the FBI even though they lie and say they don't. They can get a NSL and end up having to without being able to tell you that they did. Sometimes a NSL canary is used, but not always.