Hacker News Reader

Comment by dep_b | Hacker News Reader

Oof, magic strings. Always use enums!

    enum Booze: String {
        case wine,
        case champagne,
        case beer,
        case whiskey
    }

    let wine = [Booze.champagne]

</ocd>

wine's type should conform to a Stack protocol so you can pop champagne.

I'm not sure if it was intentional but "case beer" made me smile.

Nooooooo... you're right about enums but this codifies the same error I was trying to elucidate with code. Here, let's try this:

   enum Booze {
     case Wine(region: String)
     case Beer
     case Whiskey
   }

   let drink = Booze.Wine(region: "Champagne")

Now.. Anyone want to demonstrate how to use enums for the wine region or, say, whiskey subtypes? Should we use classes?

I feel like adding a pull request to add whisky to the list. Some of us prefer scotch.

Definitely have to +1 this. I'd be happy to write some tests to get scotch on board.

You don't need commas :)

Why are these String, not just enums?

Because it's replacing a Magic String?