Hacker News Reader

Comment by palakchokshi | Hacker News Reader

Looks pretty good and I didn't see performance issues. From a usability perspective it's simple to use. I would suggest a couple of usability improvements.

1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview.

2. In Edit mode the buttons on the bottom work like on/off buttons (that's great) those buttons should have tooltips.

3. Editing an image I can't put an alt value or title? How accessible is the content created by the editor?

Keep up the good work. I would use this for quick website/blog setup.

View on HN

Hey, thanks for the feedback! I tracked this in the repo, see: https://github.com/ory/editor/issues/389

But I will briefly address these issues here:

> 1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview.

This was actually implemented at one point, but we removed it because some people found it confusing. We might add it though.

Also keep in mind that the UI is just a component, you could simply provide your own!

> those buttons should have tooltips.

Great idea!

> 3. Editing an image I can't put an alt value or title? How accessible is the content created by the editor?

Noted, we forgot about that. You can, by the way, write your own image plugin that has an alt tag. But of course we will add this capability to the image plugin. :)

I wanted to walk you through my thought process regarding the right side buttons if you'll indulge me:

1. I clicked the edit button on the right to get in to edit mode. Edit button was highlighted in pink.

2. Saw the buttons on the bottom appear when I clicked a Text section.

3. Bolded some selected text by clicking the B button. B button got highlighted.

4. Clicked the B button again and text went back to normal and the highlight on the B got turned off. (At this point I'm thinking cool buttons are on/off. On state is indicated by a highlight, Off state is indicated as normal style)

5. Performed some other edits then clicked the Edit button the right since it was highlighted and based on my experience with the bottom buttons I expected clicking it again would turn off edit mode.

You don't have to make the change. I just wanted to walk through the thought process of one user.

Thanks for indulging me :)

Thank you for your feedback, I added it to the issue as well :)

Reply on news.ycombinator.com