Hacker News Reader

Comment by Tiksi | Hacker News Reader

> Many of the logged urls contained query strings from https requests that I don't think they intended to share.

I guess this confirms a few things.

- The complete query strings are logged,

- They don't appear to be too concerned with who accesses the logs internally or have a process that limits the access, and

- They're willing to send those logs out to a random person.

View on HN

During debugging, that seems fine. The previous sentence makes it clear that they added specific logging to track down the problem. I'd rather have a process that allows engineers debugging memory corruption to see the data that's in the process they're debugging, than a process that prohibits them from seeing it.

This has nothing to do with logging.

The quoted part that specifically mentions logged urls containing query strings has nothing to do with logging?

That's Google logging stuff

I read it as "sensitive query strings sent to Google by CloudFlare engineers".

That's not how Google tells it, if I'm reading this right:

Cloudflare explained that they pushed a change to production that logged malformed pages that were requested, and then sent me the list of URLs to double check.

Many of the logged urls contained query strings from https requests that I don't think they intended to share.

(I'm reading that as "intended to share with Google".)

Ah. I see what you mean. Apologies, kind of tired.

If Cloudflare accidentally leaked additional sensitive data to Tavis during the handling of this incident, and that data wasn't already compromised by the parser bug, then you should call that out in the incident report.

Understandably, I think. I can't imagine you've had much sleep this week.

Little

I'm sorry you (or anybody else) have to go through this.

Thanks.

FWIW, I admire you for how you're handling this, taking the grunt of the storm all by yourself and not throwing anyone under the bus. Tip of the hat to you and may better times lie ahead!

No one else's mistake other than ours.

This and the SHA1-pocalypse cannot have been a fun day.

Maybe time to consider one of the nap rooms?

I don't think that's the case: from my reading of the issue I understood that the urls with query params were sent from CF to Google for clearing from the google cache.

Reply on news.ycombinator.com