You've contradicted yourself. You initially said:

> Nothing about this attack is going to impact the effectiveness of ASLR in the cases it was designed for.

Then you said:

> This article makes it sound like ASLR has been completely defeated, but it's only defeated in a context where the attacker has significant control - even if that's a likely scenario.

That is indeed a highly likely scenario, so it's simply wrong to say "nothing about this attack is going to impact the effectiveness of ASLR".