"Onward, Christian soldiers" is not about physical war, but about spiritual warfare. Killing isn't usually performed by singing hymns, for example:
Hell’s foundations quiver
At the shout of praise;
Brothers, lift your voices,
Loud your anthems raise.