Hacker News Reader

Comment by yokohummer7 | Hacker News Reader

The slowness shown in the pre-1.9 terminal is a bit ridiculous. Was it really the case? I've never seen such a strangely-behaving emulator! Really good that they resolved the issue.

View on HN

Hi, I worked on those improvements. Yes that is indeed what would happen when you ran a command with heaps of output, it would also lock up the UI while doing it. You probably haven't observed it much as you don't do recursive directory walk on a large directory ;)

You can read more about the specifics if you're interested in https://github.com/Microsoft/vscode/issues/17875

Hey, just wanted to say thanks for working on VS Code, I use it every day, love it!

Great, I didn't know the terminal portion if VS Code exists as a separate project. Was it made to fuel VS Code? Or did it already exist before launching VS Code?

I also liked the name of the project, xterm.js. :)

Looks like xterm.js was started by Sourcelair, which looks like a Cloud IDE.

It already existed, you can see when we started shipping the integrated terminal pretty clearly from the contribution graph :) https://github.com/sourcelair/xterm.js/graphs/contributors

The project itself is a fork of the popular term.js which is now unmaintained, we've taken it quite far since then. Hyper are probably going to be making a switch once a few more kinks are worked out too https://github.com/zeit/hyper/issues/1275

Thanks for working on this!

Thanks for your work on this! The addition and consistent improvement of the integrated terminal is the number one reason why VSCode is my daily driver.

The gained performance in the current release (and in Insiders for the past days) is huge - even without heaps of output. Those couple of milliseconds improved rendering time matter even if you "only" ls in a directory.

Thumbs up for this, Daniel. Thanks.

Yeah, that was the main reason I didn't use it a lot actually. Powershell is slow to begin with and in VSC it was just 10x slower and buggy.

I am very happy that this is solved.

It was noticeable, but only really bad in some very specific cases (disk I/O?).

Reply on news.ycombinator.com