The Swedish tax authority has several documents on how they judge such cases, and in general, a company doing this is unlikely to be seen as a "no strings attached" gift. If it comes from an advertisement budget, someone somewhere is expecting a return on investment.
The league - his employer - reminded him of the conditions of his employment. There was nothing preventing him from wearing Adidas from HEAD TO TOE as long as it wasn't in a direct situation sponsored by his employer. Thus, he actually had TWO sponsorships in some terms.
He wanted to wear his Adidas on the field, but was not allowed, even though it was completely above the board. So, where do you draw the line? Can your employer tell you what brand of clothing to wear? If he got the shoes for free, should RGIII be allowed to undermine the other contract?
My perspective is that the line of reasoning you present is inherently flawed. Are you not aware that Nike essentially got its foothold (pun intended) by giving away shoes to college basketball programs and people who probably couldn't afford to buy them? It was covered in an ESPN 30 for 30 so there's the citation.
From your context it sounds like you believe - maybe it's my interpretation - that things given to celebrities for free are "no strings attached" and I think that's been proven wrong time and again. Contracts, handshake deals, they don't work that way. There's either an explicit (preferred) or implied (bad) debt to be paid. It takes time to learn how these systems work, and woe to those who might minimize their practical implementations.
Oh, and a Youtuber who receives free stuff better disclose it, because if they're in the US, then they have the IRS to deal with. The IRS doesn't screw around with compensation. Dollars or donuts, keep the receipts[1]!
[1] Excluding Mitch Hedberg, who accurately pointed out a donut in regular guy life does not need a receipt.
I don't really see any ambiguity here. Just ask, "Would I want to know about this if the celebrity's actions were a factor in my purchase?"