In some ways learning a really flexible language like Lisp can turn you even into a really bad developer. I say "developer" instead of "programer" because I want to emphasize working with others and thus sharing code with others. Of course this is based on some past observations working with MIT grads and various other academia so take my opinion with a grain of salt.
IMO the language that really changed everything for me was the ML family of languages and maybe C. I would say knowing C and ML is more worthwhile than Lisp (Lisp is not exactly hard to learn anyway... the basics that is).
I'd say that learning X really well is always a positive because whenever you learn something in depth you can then apply the concepts elsewhere. And there are still lisp-only concepts, so learning lisp is positive. ML is good too. Also spending time with a well designed concurrent language is beneficial.
I can't really explain it but the whole variant/ADT pattern matching really forces to make you think of your problem domain as a specification or language (e.g. DSL). It is one of the reason why I think so many compilers are written in ML (that and the toolset is awesome for it).
With Lisp macros, though, you change the syntax of Lisp. You take things that were not valid Lisp syntax, and you make them valid for your program.
So ML "language building" is in terms of semantics, but in Lisp, it's both semantics and syntax. (Again, IIUC).
I've written Clojure professionally now for a couple years and am pretty fast and proficient at it, but when I write a function call, I don't think of it as a list, even though that is what it is. I don't think any lisper does. It's just a function with arguments and I'm writing in the syntax necessary, which happens to be a list.
In those rare occasions where I think a macro is necessary, sure, it helps that a function call is a list, but that's hardly the main role in a day's work.
I do actually think of my code as a tree/graph structure. Not just in lisps but in other languages as well, I'm always manipulating a stack of trees and thinking about how the data flows through the branches.
That's true with any lisp. But that doesn't mean the the ability to write macros is a requirement for most development work on a daily basis, and homoiconicity is often touted as amazing specifically because of its help in writing macros. Therefore, since writing macros is not super common or necessary most of the time, I would say that "code as data" is also not a big deal most of the time.
I really like lisp, I just don't think some of its unique features are as big a deal as they advertise.
In Javascript, also, effectively you have to work with code as data.
So this isn't just about writing macros. There are a lot of areas where this does touch things.
However, that's part of the process too as is learning when to use a hammer vs a wrench vs a screwdriver. There is the point in learning a new tool where everything looks like a nail. Yes, people will really mess things up by applying the wrong concepts but how else do we learn?
a) code as data
b) interactive software development
c) user-defined language extensions where the developer is part-time language designer, syntactic abstraction
d) dynamic object-oriented programming
e) meta-object programming
This enables you to have large OO applications running and change them while they are running. This enables interactive incremental development.
Interaction with LispWorks:
Define a class with a slot.
CL-USER 61 > (defclass person () ((name :initarg :name)))
#<STANDARD-CLASS PERSON 4020002153>
Create an instance of that class. CL-USER 62 > (defparameter *p1* (make-instance 'person :name "Drumpf"))
*P1*
What is it? CL-USER 63 > (describe *p1*)
#<PERSON 402000DE43> is a PERSON
NAME "Drumpf"
Hmm, let's make a politician class, with person as superclass and a slot TYPE. CL-USER 64 > (defclass politician (person) ((type :initarg :type)))
#<STANDARD-CLASS POLITICIAN 4020284743>
We change our object to the new class and add information about the new slot content: CL-USER 65 > (change-class *p1* 'politician :type 'populist)
#<POLITICIAN 402000DE43>
What is it now? CL-USER 66 > (describe *p1*)
#<POLITICIAN 402000DE43> is a POLITICIAN
TYPE POPULIST
NAME "Drumpf"
Class of the instance has changed, the new slot has been added, and the old slot is still there. (mkunbound '*p1*)