Hydrogen is low energy density and next to impossible to contain or transport without lossage. These are major barriers to commercial adoption absent a breakthrough, laying aside the problem of generation.
Lossage is certainly a problem, but I think once your aircraft is airborne, you can basically burn any hydrogen as it outgasses.