Comment by diggan | Hacker News Reader

Comment by diggan | Hacker News Reader

Parent Full thread

Ah, thanks to sytse, Snappy and tmaczukin for the replis. I missed that.

My configuration looks like this currently (and I'm guessing I'll hold of for a few days for the shared workers to get updated):

  image: docker:latest
  services:
  - docker:dind
  stages:
    - build
    - deploy
  build:
    stage: build
    script:
      - docker build -t registry.gitlab.com/victorbjelkholm/deploy-html-test:latest .
    only:
      - master
  deploy:
    stage: deploy
    script:
      - docker push registry.gitlab.com/victorbjelkholm/deploy-html-test:latest
    only:
      - master

If you're going to use the shared runners, I don't think that configuration is going to work. The build step will build it locally, and even though you named it to use the registry, it won't actually push to the registry automatically. By breaking up the push to another step, you're actually going to run that deploy stage on a fresh Digital Ocean instance, so your previously-built image will be lost.

That's why the example pushed the image right after the build step.

Having said that, if you're literally using that script, you don't even have tests, so you may as well just put both steps into a single build stage like the simplified example. :)

For now, you'll need the explicit `docker login` as well. We'll work to remove that.

Thanks, you didn't miss anything in the blog post, we updated the blog post. https://gitlab.com/gitlab-com/www-gitlab-com/commit/c758f6b2...

Reply on news.ycombinator.com