Show HN: PatchBin.com - Pastebin for patches + comments + code review. | Hacker News Reader

Show HN: PatchBin.com - Pastebin for patches + comments + code review.

patchbin.com

45 pointsantileet13 comments

Open articleView on HN

XSS open. http://github.com/ninjagod/patchbin/issues#issue/1

I disabled escaping because it had trouble rendering XML code. I thought it was safe but I was wrong.

Fixing now. Thanks! [edit] fixed

I played a bit with code and I think you could benefit from reading:

http://www.python.org/dev/peps/pep-0008/

http://docs.djangoproject.com/en/dev/topics/forms/

http://docs.djangoproject.com/en/dev/topics/db/models/#many-...

I know horizontal space is tight, but it'd be nice if you could have 2 at-least-80-character-wide views (rather than hard-wrapping them at whatever they are now) when you have a wider screen. Looks good though.

Agreed. 80 characters is the bare minimum for code viewing. The choice of 55, which this seems to be, is extremely odd considering it's designed to view diffs (which technically means 81 or 82 for the leading edit indicator chars).

Thanks!

I'm having a tough time with CSS right now. I hope to add a client-side way to detect when the screen is large enough and show 80 character wide views.

$(window).width() will display the viewable width of the client in jQuery. and onResize will fire on <body> when the window is resized. (food for thought)

I think this is a pretty neat idea. Often a coworker is working remotely and our boss has been begging for some code review. This could have some use.

I really like this implementation. Very clean, effective, and simple. I hope you continue to make progress on it ^_^.

To the folks who tried out the commenting:

A lot of comments are blank. If you entered valid text and that didn't get written to the database, and is a bug. Can you please describe any bad experience you had with the commenting system.

Thanks!

You might want to put a "cancel" button on the comment form. The blank comments might be people who are trying to get rid of the comment form after accidentally double-clicking.