I don't think that Apple makes a lot of money from repairs, as claimed by this (rather silly) article. It's more a case that iPhones, MacBooks, etc are designed and manufactured for thinness, irregular battery shapes, etc, so that they don't lend themselves well to end user repair. There are many other device options out there for people who don't like this approach.