Hacker News Reader

Comment by sandofsky | Hacker News Reader

This library provides so many anti-patterns. "topMostVC" is going to be the source of a ton of bugs.

As for aesthetics, this library will be adopted by a lot of people who don't understand Cocoa conventions. If I saw it part of a project, I'd consider it a red flag.

View on HN

Thanks for the feedback. I used this in 3 different app projects and topMostVC actually reduced bugs, crashes and weird looking views. If there is anything in particular I should look out for, let me know!

If topMostVC fixed your bugs, you probably aren't following Cocoa patterns. You're probably introducing new, subtler bugs.

Honestly, I think you just need more experience before attempting a library like this.

It doesn't fix bugs. It lowers the amount of bugs to be handled in comparison to trying to present on top of a class. And maybe the example is kind of deceiving, actually it is meant for alerts and small views and stuff like that, not pushing real full screen UIViewControllers.

It's been awhile since I looked at this, but tab bar controllers (selectedViewController), navigation controllers (topViewController), and child controllers are probably going to cause your current method some difficulties.

Can you give me examples on what kind?

A navigation controller presenting a tab bar controller presenting a navigation controller with a child controller presenting a tab bar controller… on an iPad. Or any set of permutations of those.

Yeah that would actually break it.

Reply on news.ycombinator.com