I thought I had seen that code snippet before, it was also quoted as a bad example in a more recent article on the Dolphin dev blog regarding the Zelda HLE (this one is about the AX HLE): https://dolphin-emu.org/blog/2015/08/19/new-era-hle-audio/