Show HN: Mini_printf – minimal, self-contained and verified printf() | Hacker News Reader

Show HN: Mini_printf – minimal, self-contained and verified printf()

github.com

22 pointswkoszek9 comments

Calling it verified seems like a stretch. When I think verified, I think seL4, CompCert, etc. The role of testing isn't verification, it's falsification.

I agree it's a mistake. I made the change to the README.md and gave you a credit for spotting it.

https://github.com/wkoszek/mini_printf/commit/fb096cabb5dcba...

  typedef unsigned int	u32;
  typedef unsigned long	u64;

This does not look like portable code.

The problem is that I didn't want to make this code depend on stdint.h

So yeah - depending on the platform you will need to make u32/u64 point to things from your stdint.h (or whatever that is) and the code should work.

Though your code converts the input int to u32 when calling vpf_num_to_str. That will fail if int happens to be more than 32 bits long.

Anyway, a less theoretical bug report: Your "%d" format specifier fails to print negative numbers. :)

>I didn't want to make this code depend on stdint.h

Why?

Some environments don't have stdint.h

Your code does not seem to mention its license anywhere. This makes it impossible to use in most projects. For commercial embedded a BSD-style license seems to be better. For using it in GPL software GPL would work better. IANAL but without a license and a copyright notice depending on the country the viewer is in it might be even up for grabs for them to put on their own copyright and license.

Good point, since I forgot. It's a BSDv2 code. Credit goes to you:

https://github.com/wkoszek/mini_printf/commit/1fbf606cb23f2e...

Reply on news.ycombinator.com